Pr/189 update #258
Open
Pr/189 update #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]>
HalosGhost
force-pushed
the
pr/189-update
branch
9 times, most recently
from
a6fddab
to
837987e
Compare
In particular, several of the commits in this set assume their `blocking_queue`s will be empty by the time the destructor is called. However, this is not guaranteeable, and causes segfaults and/or indefinite hangs when encountered. This commit predominantly ensures that the queues are all `clear()`d appropriately. Signed-off-by: Sam Stuewe <[email protected]>
HalosGhost
force-pushed
the
pr/189-update
branch
from
837987e
to
f86ef09
Compare
|
I've not yet addressed Anders's suggestion. Hoping to test that later this week. |
|
@anders94 I did some initial (read: not thorough) testing reducing the validation-thread-count in the coordinators/shards by 1, and see negligible difference (if anything slightly higher latency / lower throughput); but I've not tested at particularly large configurations. Do you have time later today or tomorrow to hop on a call and I can walk through the preliminary results I have and we can see if it feels like I should run a few more tests (i.e., just to eliminate the possibility of noise, or at larger configurations to potentially amplify the effects)? |
|
Yep, let's do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply rebases and updates #189.
I've done a bit of local testing, and this dramatically reduces the impact of enabling sentinel attestations.
@anders94 had a suggestion to prefer
n_threads==std::thread::hardware_concurrency() - 1; I'm going to run a few tests to see if one or the other has an obvious performance benefit, and then I believe this is likely ready-to-merge.